Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTER USER use LOGIN resets failed attempt count #14444

Merged
merged 2 commits into from
Feb 12, 2025
Merged

ALTER USER use LOGIN resets failed attempt count #14444

merged 2 commits into from
Feb 12, 2025

Conversation

flown4qqqq
Copy link
Collaborator

Changelog entry

The ALTER USER user LOGIN query should unban the user who has been banned for exceeding the limit of authentication attempts.

Changelog category

  • Improvement

Additional information

@flown4qqqq flown4qqqq self-assigned this Feb 11, 2025
@flown4qqqq flown4qqqq changed the title ALTER USER use LOGIN resets fauled attempt count ALTER USER use LOGIN resets failed attempt count Feb 11, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

⚪ 2025-02-11 13:37:22 UTC Pre-commit check linux-x86_64-release-asan for 7ef3039 has started.
⚪ 2025-02-11 13:37:34 UTC Artifacts will be uploaded here
⚪ 2025-02-11 13:40:39 UTC ya make is running...
🟡 2025-02-11 14:52:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13303 13231 0 22 15 35

⚪ 2025-02-11 14:54:10 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-11 15:07:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 74 0 1 5 33

⚪ 2025-02-11 15:07:32 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-11 15:19:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 32 0 0 4 31

🟢 2025-02-11 15:19:26 UTC Build successful.
🟢 2025-02-11 15:19:58 UTC ydbd size 3.6 GiB changed* by +3.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8b46b94 merge: 7ef3039 diff diff %
ydbd size 3 876 010 832 Bytes 3 876 014 480 Bytes +3.6 KiB +0.000%
ydbd stripped size 1 357 290 928 Bytes 1 357 291 824 Bytes +896 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 11, 2025 •
edited
Loading

⚪ 2025-02-11 13:39:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7ef3039 has started.
⚪ 2025-02-11 13:39:17 UTC Artifacts will be uploaded here
⚪ 2025-02-11 13:42:13 UTC ya make is running...
🟡 2025-02-11 14:48:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27459 24874 0 1 2450 134

⚪ 2025-02-11 14:51:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-11 15:03:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
207 (only retried tests) 79 0 0 1 127

🟢 2025-02-11 15:04:05 UTC Build successful.
🟢 2025-02-11 15:04:27 UTC ydbd size 2.1 GiB changed* by +35.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 250f3cc merge: 7ef3039 diff diff %
ydbd size 2 228 810 896 Bytes 2 228 847 600 Bytes +35.8 KiB +0.002%
ydbd stripped size 473 237 272 Bytes 473 239 384 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@flown4qqqq flown4qqqq requested a review from a team as a code owner February 12, 2025 10:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

⚪ 2025-02-12 10:54:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5c0d721 has started.
⚫ 2025-02-12 10:54:40 UTC Check cancelled

@flown4qqqq flown4qqqq force-pushed the improve-login-nologin branch from 8a26683 to 5a5ed5c Compare February 12, 2025 10:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

⚪ 2025-02-12 10:57:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for f5b2135 has started.
⚪ 2025-02-12 10:58:40 UTC Artifacts will be uploaded here
⚪ 2025-02-12 11:02:04 UTC ya make is running...
🟢 2025-02-12 12:08:31 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27462 24885 0 0 2444 133

🟢 2025-02-12 12:10:54 UTC Build successful.
🟢 2025-02-12 12:11:12 UTC ydbd size 2.1 GiB changed* by +552 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: dac5bad merge: f5b2135 diff diff %
ydbd size 2 229 091 480 Bytes 2 229 092 032 Bytes +552 Bytes +0.000%
ydbd stripped size 473 266 328 Bytes 473 266 456 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

⚪ 2025-02-12 11:00:23 UTC Pre-commit check linux-x86_64-release-asan for f5b2135 has started.
⚪ 2025-02-12 11:00:27 UTC Artifacts will be uploaded here
⚪ 2025-02-12 11:03:25 UTC ya make is running...
🟡 2025-02-12 12:20:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13306 13226 0 27 16 37

⚪ 2025-02-12 12:21:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-12 12:43:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
125 (only retried tests) 83 0 0 9 33

🟢 2025-02-12 12:43:43 UTC Build successful.
🟢 2025-02-12 12:44:12 UTC ydbd size 3.6 GiB changed* by +912 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: dac5bad merge: f5b2135 diff diff %
ydbd size 3 876 459 192 Bytes 3 876 460 104 Bytes +912 Bytes +0.000%
ydbd stripped size 1 357 380 752 Bytes 1 357 381 008 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@flown4qqqq flown4qqqq requested a review from ijon February 12, 2025 13:37
@flown4qqqq flown4qqqq merged commit 335d81a into ydb-platform:main Feb 12, 2025
12 checks passed
This was referenced Feb 12, 2025
Merged
Open
lberserq pushed a commit to lberserq/ydb that referenced this pull request Feb 14, 2025
@flown4qqqq
ALTER USER use LOGIN resets failed attempt count (ydb-platform#14444)
454b782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijon ijon ijon approved these changes

@molotkov-and molotkov-and molotkov-and approved these changes

Assignees

@flown4qqqq flown4qqqq

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flown4qqqq @ijon @molotkov-and